$ node scripts/check-changed.ts ⊘ cache disabled
check:changed: 2 files since 3e9d97ae1f7c

> vp format  pass  1.8s
Checking formatting...

All matched files use the correct format.
Finished in 1330ms on 2 files using 4 threads.

> vp graphql (apps/server)  pass  2.5s
~/apps/server$ graphqlgen --check ⊘ cache disabled


> vp lint  pass  4.3s
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts:11125:7: warning eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'. help: Consider removing this declaration.

> vp typecheck (2 packages)  pass  37.8s
~/scripts$ tsc --noEmit ◉ cache hit, replaying
mobile-native-client.ts:451:3 - suggestion TS377095: `Effect.orElseSucceed` expresses the same recovery more directly than `Effect.catch` followed by `Effect.succeed`. effect(catchToOrElseSucceed)

451   Effect.catch(() => Effect.succeed(null)),
      ~~~~~~~~~~~~


~/apps/server$ tsc --noEmit ○ cache miss: 'apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts' modified, executing
scripts/acp-mock-agent.ts:940:16 - suggestion TS377015: This expression contains chained `pipe` calls that can be simplified to a single `pipe` call. effect(unnecessaryPipeChain)

940         yield* Effect.sleep("1200 millis")
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
941           .pipe(
    ~~~~~~~~~~~~~~~~
... 
953           )
    ~~~~~~~~~~~
954           .pipe(Effect.forkDetach);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

scripts/record-codex-app-server-replay-fixture.ts:1167:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("logger")((event) => { ... })`. effect(effectFnOpportunity)

1167     logger: (event) => {
         ~~~~~~

scripts/record-grok-acp-replay-fixture.ts:370:38 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeSync` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownSync`. effect(preferTypedSchemaDecoder)

370 const DEFAULT_GROK_SETTINGS = Schema.decodeUnknownSync(GrokSettings)({});
                                         ~~~~~~~~~~~~~~~~~

src/assets/AssetAccess.test.ts:1247:42 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeEffect` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownEffect`. effect(preferTypedSchemaDecoder)

1247       const { resource } = yield* Schema.decodeUnknownEffect(AssetCreateUrlInput)({
                                              ~~~~~~~~~~~~~~~~~~~

src/auth/EnvironmentAuth.ts:1377:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("EnvironmentAuth.getDescriptor")(() => { ... })`. effect(effectFnOpportunity)

1377     getDescriptor: () =>
         ~~~~~~~~~~~~~

src/auth/EnvironmentAuthPolicy.ts:55:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("EnvironmentAuthPolicy.getDescriptor")(() => { ... })`. effect(effectFnOpportunity)

55     getDescriptor: () =>
       ~~~~~~~~~~~~~

src/auth/McpOAuth.ts:530:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("McpHttpServer.McpClientAuthenticator.authenticate")((request) => { ... })`. effect(effectFnOpportunity)

530       authenticate: (request) =>
          ~~~~~~~~~~~~

src/cli/thread.ts:468:11 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

468         : Effect.succeed(undefined),
              ~~~~~~~~~~~~~~~~~~~~~~~~~

src/cloud/CliTokenManager.ts:326:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("HttpClientError")(function*(cause) { ... })`. effect(effectFnOpportunity)

326       HttpClientError: (cause) =>
          ~~~~~~~~~~~~~~~

src/cloud/CloudLink.lifecycle.test.ts:166:21 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

166             latest: Effect.succeed(Option.none()),
                        ~~~~~~~~~~~~~~

src/cloud/CloudLink.test.ts:99:17 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

99         latest: Effect.succeed(Option.none()),
                   ~~~~~~~~~~~~~~

src/cloud/ManagedEndpointRuntime.ts:762:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("CloudManagedEndpointRuntime.requestRecovery")((config) => { ... })`. effect(effectFnOpportunity)

762     requestRecovery: (config) => Queue.offer(recoveryRequests, config).pipe(Effect.asVoid),
        ~~~~~~~~~~~~~~~

src/cloud/http.test.ts:81:67 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

81     Layer.mock(ConnectReachability.ConnectReachability)({ latest: Effect.succeed(Option.none()) }),
                                                                     ~~~~~~~~~~~~~~

src/cloud/selfUpdate.ts:371:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSelfUpdate.commitDesktopUpdate")((requestId, onHandoffAccepted) => { ... })`. effect(effectFnOpportunity)

371     commitDesktopUpdate: (requestId, onHandoffAccepted) =>
        ~~~~~~~~~~~~~~~~~~~

src/device/DeviceService.ts:807:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DeviceService.updateTool")((tool) => { ... })`. effect(effectFnOpportunity)

807       updateTool: (tool) =>
          ~~~~~~~~~~

src/device/DeviceService.ts:822:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DeviceService.easAccount")(() => { ... })`. effect(effectFnOpportunity)

822       easAccount: () =>
          ~~~~~~~~~~

src/device/EasDeviceHost.ts:865:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DeviceHost.DeviceHost.ensureAgentReady")((onPhase) => { ... })`. effect(effectFnOpportunity)

865     ensureAgentReady: (onPhase) =>
        ~~~~~~~~~~~~~~~~

src/device/easProjectId.ts:181:7 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

181       Effect.map(Option.some),
          ~~~~~~~~~~

src/environment/DirectEndpoints.ts:158:31 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DirectEndpoints.resolve")(() => { ... })`. effect(effectFnOpportunity)

158   return DirectEndpoints.of({ resolve: () => resolve });
                                  ~~~~~~~

src/environment/RemoteOpenTargets.ts:81:33 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("RemoteOpenTargets.resolveTargets")(() => { ... })`. effect(effectFnOpportunity)

81   return RemoteOpenTargets.of({ resolveTargets: () => resolveTargets });
                                   ~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:302:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.isRepository")((cwd) => { ... })`. effect(effectFnOpportunity)

302     isRepository: (cwd) =>
        ~~~~~~~~~~~~

src/git/GitWorkflowService.ts:315:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.hasCommit")((input) => { ... })`. effect(effectFnOpportunity)

315     hasCommit: (input) =>
        ~~~~~~~~~

src/git/GitWorkflowService.ts:327:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.hasRefNamed")((input) => { ... })`. effect(effectFnOpportunity)

327     hasRefNamed: (input) =>
        ~~~~~~~~~~~

src/git/GitWorkflowService.ts:346:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.status")((input) => { ... })`. effect(effectFnOpportunity)

346     status: (input) =>
        ~~~~~~

src/git/GitWorkflowService.ts:352:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.localStatus")((input) => { ... })`. effect(effectFnOpportunity)

352     localStatus: (input) =>
        ~~~~~~~~~~~

src/git/GitWorkflowService.ts:360:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.remoteStatus")((input, options) => { ... })`. effect(effectFnOpportunity)

360     remoteStatus: (input, options) =>
        ~~~~~~~~~~~~

src/git/GitWorkflowService.ts:369:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.pullCurrentBranch")((cwd) => { ... })`. effect(effectFnOpportunity)

369     pullCurrentBranch: (cwd) =>
        ~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:373:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.runStackedAction")((input, options) => { ... })`. effect(effectFnOpportunity)

373     runStackedAction: (input, options) =>
        ~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:388:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.preparePullRequestThread")((input) => { ... })`. effect(effectFnOpportunity)

388     preparePullRequestThread: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:399:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.listRefs")((input) => { ... })`. effect(effectFnOpportunity)

399     listRefs: (input) =>
        ~~~~~~~~

src/git/GitWorkflowService.ts:405:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.createWorktree")((input, options) => { ... })`. effect(effectFnOpportunity)

405     createWorktree: (input, options) =>
        ~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:409:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.listLocalBranchNames")((cwd) => { ... })`. effect(effectFnOpportunity)

409     listLocalBranchNames: (cwd) =>
        ~~~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:413:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.fetchRemote")((input) => { ... })`. effect(effectFnOpportunity)

413     fetchRemote: (input) =>
        ~~~~~~~~~~~

src/git/GitWorkflowService.ts:417:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.remoteExists")((input) => { ... })`. effect(effectFnOpportunity)

417     remoteExists: (input) =>
        ~~~~~~~~~~~~

src/git/GitWorkflowService.ts:421:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.remoteBranchExists")((input) => { ... })`. effect(effectFnOpportunity)

421     remoteBranchExists: (input) =>
        ~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:425:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.resolveRemoteTrackingCommit")((input) => { ... })`. effect(effectFnOpportunity)

425     resolveRemoteTrackingCommit: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:429:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.resolveWorktreeBaseRemote")((input) => { ... })`. effect(effectFnOpportunity)

429     resolveWorktreeBaseRemote: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:433:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.fetchWorktreeBaseCommit")((input) => { ... })`. effect(effectFnOpportunity)

433     fetchWorktreeBaseCommit: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:437:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.removeWorktree")((input) => { ... })`. effect(effectFnOpportunity)

437     removeWorktree: (input) =>
        ~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:441:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.pruneWorktrees")((input) => { ... })`. effect(effectFnOpportunity)

441     pruneWorktrees: (input) =>
        ~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:445:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.deleteLocalBranch")((input) => { ... })`. effect(effectFnOpportunity)

445     deleteLocalBranch: (input) =>
        ~~~~~~~~~~~~~~~~~

src/git/GitWorkflowService.ts:449:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.createRef")((input) => { ... })`. effect(effectFnOpportunity)

449     createRef: (input) =>
        ~~~~~~~~~

src/git/GitWorkflowService.ts:457:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.switchRef")((input) => { ... })`. effect(effectFnOpportunity)

457     switchRef: (input) =>
        ~~~~~~~~~

src/git/GitWorkflowService.ts:463:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitWorkflowService.renameBranch")((input) => { ... })`. effect(effectFnOpportunity)

463     renameBranch: (input) =>
        ~~~~~~~~~~~~

src/guest/GuestShareService.test.ts:633:9 - suggestion TS377014: This generator returns an Effect-able value directly, which produces a nested `Effect<Effect<...>>`. If the intended result is the inner Effect value, `return yield*` represents that form. effect(returnEffectInGen)

633         return guestShares.submit(
            ~~~~~~

src/htmlRender/headlessChrome.ts:268:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("receive")((raw) => { ... })`. effect(effectFnOpportunity)

268   const receive = (raw: string) => {
            ~~~~~~~

src/mcp/AcpMcpStdioBridge.ts:277:7 - suggestion TS377012: This Effect generator contains `try/catch`; in this context, error handling is expressed with Effect APIs such as Effect.try, Effect.tryPromise, Effect.catch, Effect.catchTag). effect(tryCatchInEffectGen)

277       try {
          ~~~~~
278         parsed = JSON.parse(line);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
280         return yield* respondWithError(null, "Parse error", -32700);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
281       }
    ~~~~~~~

src/mcp/AcpMcpStdioBridge.ts:317:7 - suggestion TS377099: `Effect.ignoreCause` expresses ignored failure more directly than `Effect.catchCause` returning `Effect.void`. effect(catchToIgnore)

317       Effect.catchCause(() => Effect.void),
          ~~~~~~~~~~~~~~~~~

src/mcp/McpDeviceToolkit.test.ts:105:18 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

105   getById: () => Effect.succeed(Option.none()),
                     ~~~~~~~~~~~~~~

src/mcp/McpHttpServer.ts:403:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("previewSnapshotFailure")(<E>(cause) => { ... })`. effect(effectFnOpportunity)

403 const previewSnapshotFailure = <E>(cause: Cause.Cause<E>) => {
          ~~~~~~~~~~~~~~~~~~~~~~

src/mcp/McpHttpServer.ts:906:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("McpServer.McpServer.addTool")((options) => { ... })`. effect(effectFnOpportunity)

906       addTool: (options) =>
          ~~~~~~~

src/mcp/McpSessionRegistry.testkit.ts:22:20 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

22     resolve: () => Effect.succeed(undefined),
                      ~~~~~~~~~~~~~~~~~~~~~~~~~

src/mcp/McpToolAccess.ts:105:7 - suggestion TS377132: `Effect.andThen` expresses this sequencing more directly than `Effect.flatMap` with a zero-parameter callback. effect(flatMapIgnoredParamToAndThen)

105       Effect.flatMap(() => writingCaller),
          ~~~~~~~~~~~~~~

src/mcp/OrchestratorMcpService.ts:2451:39 - suggestion TS377088: This generator applies the same inline `Effect.mapError(...)` to every yielded effect. Keep that `Effect.mapError(...)` inline and hoist it once to the generator result: `Effect.gen(...).pipe(Effect.mapError(...))`, or `Effect.fn(function*(){ ... }, Effect.mapError(...))`. effect(redundantMapError)

2451       const cancelOrphan = Effect.gen(function* () {
                                           ~~~~~~~~~

  src/mcp/OrchestratorMcpService.ts:2466:17 - This repeated `Effect.mapError(...)` site participates in the hoistable generator-wide mapping. effect(redundantMapError)
    2466           .pipe(Effect.mapError(threadManagementFailure));
                         ~~~~~~~~~~~~~~~

  src/mcp/OrchestratorMcpService.ts:2469:17 - This repeated `Effect.mapError(...)` site participates in the hoistable generator-wide mapping. effect(redundantMapError)
    2469           .pipe(Effect.mapError(threadManagementFailure));
                         ~~~~~~~~~~~~~~~

src/mcp/PreviewAutomationBroker.ts:650:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("onNone")(function*() { ... })`. effect(effectFnOpportunity)

650         onNone: () =>
            ~~~~~~

src/mcp/WorktreeMcpService.test.ts:353:3 - suggestion TS377017: This Effect.gen contains a single return statement. effect(unnecessaryEffectGen)

353   Effect.gen(function* () {
      ~~~~~~~~~~~~~~~~~~~~~~~~~
354     return yield* WorktreeMcpService.WorktreeMcpService;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
355   }).pipe(Effect.provide(harness.layer));
    ~~~~

src/mcp/toolkits/pullRequests/handlers.ts:223:27 - suggestion TS377015: This expression contains chained `pipe` calls that can be simplified to a single `pipe` call. effect(unnecessaryPipeChain)

223     const thread = yield* engine
                              ~~~~~~
224       .getThreadShell(threadId)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
225       .pipe(Effect.map(Option.fromNullishOr))
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
226       .pipe(Effect.mapError((cause) => new Failure({ cause })));
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/mcpApps/McpAppModelContext.ts:94:27 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("McpAppModelContext.set")(() => { ... })`. effect(effectFnOpportunity)

94   McpAppModelContext.of({ set: () => Effect.void, forThread: () => Effect.succeed([]) }),
                             ~~~

src/mcpApps/McpAppModelContext.ts:94:51 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("McpAppModelContext.forThread")(() => { ... })`. effect(effectFnOpportunity)

94   McpAppModelContext.of({ set: () => Effect.void, forThread: () => Effect.succeed([]) }),
                                                     ~~~~~~~~~

src/observability/BrowserTraceCollector.ts:16:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("BrowserTraceCollector.record")((records) => { ... })`. effect(effectFnOpportunity)

16     record: (records) =>
       ~~~~~~

src/observability/EventLoopMonitor.ts:38:49 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

38   defaultValue: () => ({ latestNoticeableStall: Effect.succeed(undefined) }),
                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts:30:32 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeSync` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownSync`. effect(preferTypedSchemaDecoder)

30 const REPLAY_SETTINGS = Schema.decodeUnknownSync(AcpRegistrySettings)({
                                  ~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts:51:17 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

51   defaultModel: Effect.succeed(undefined),
                   ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts:172:23 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

172         defaultModel: Effect.succeed(undefined),
                          ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts:340:23 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

340         defaultModel: Effect.succeed(undefined),
                          ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts:589:23 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

589         defaultModel: Effect.succeed(undefined),
                          ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts:1011:26 - suggestion TS377111: `AbortController` is manually constructed inside Effect code. Use `Effect.abortSignal` for Effect-managed cancellation. effect(abortControllerInEffect)

1011       const controller = new AbortController();
                              ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts:1362:37 - suggestion TS377015: This expression contains chained `pipe` calls that can be simplified to a single `pipe` call. effect(unnecessaryPipeChain)

1362         const requestEvent = yield* runtime.events
                                         ~~~~~~~~~~~~~~
1363           .pipe(
     ~~~~~~~~~~~~~~~~
 ... 
1366           )
     ~~~~~~~~~~~
1367           .pipe(Effect.forkScoped);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts:1368:28 - suggestion TS377111: `AbortController` is manually constructed inside Effect code. Use `Effect.abortSignal` for Effect-managed cancellation. effect(abortControllerInEffect)

1368         const controller = new AbortController();
                                ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts:1391:37 - suggestion TS377111: `AbortController` is manually constructed inside Effect code. Use `Effect.abortSignal` for Effect-managed cancellation. effect(abortControllerInEffect)

1391         const cancelledController = new AbortController();
                                         ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts:1515:28 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

1515                     return yield* Effect.fail(
                                ~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.ts:4354:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapter.ProviderAdapterV2.getCapabilities")(() => { ... })`. effect(effectFnOpportunity)

4354     getCapabilities: () => Effect.succeed(ClaudeProviderCapabilitiesV2),
         ~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAdapterV2.ts:4355:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapter.ProviderAdapterV2.planSelectionTransition")(() => { ... })`. effect(effectFnOpportunity)

4355     planSelectionTransition: () => Effect.succeed(turnScopedSelectionTransition()),
         ~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeAgentSdkQueryRunner.test.ts:199:17 - suggestion TS377111: `AbortController` is manually constructed inside Effect code. Use `Effect.abortSignal` for Effect-managed cancellation. effect(abortControllerInEffect)

199         signal: new AbortController().signal,
                    ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/ClaudeTaskOutputTail.ts:59:17 - suggestion TS377121: This Effect first-completion race has exactly one sleep- or delay-based timer arm. `Effect.timeoutOrElse` expresses the timeout and fallback directly. effect(raceFirstWithSleepToTimeout)

59   const pause = Effect.raceFirst(
                   ~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:1703:25 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

1703     threadId === null ? Effect.succeed(undefined) : mcpSessions.read(threadId);
                             ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:1710:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapter.ProviderAdapterV2.getCapabilities")(() => { ... })`. effect(effectFnOpportunity)

1710     getCapabilities: () => Effect.succeed(CodexProviderCapabilitiesV2),
         ~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:1711:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapter.ProviderAdapterV2.planSelectionTransition")(() => { ... })`. effect(effectFnOpportunity)

1711     planSelectionTransition: () => Effect.succeed(turnScopedSelectionTransition()),
         ~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:2987:19 - suggestion TS377095: `Effect.orElseSucceed` expresses the same recovery more directly than `Effect.catch` followed by `Effect.succeed`. effect(catchToOrElseSucceed)

2987                   Effect.catch(() => Effect.succeed(null)),
                       ~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:2988:19 - suggestion TS377120: `Effect.filterOrElse` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

2988                   Effect.flatMap((response) =>
                       ~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:3010:19 - suggestion TS377099: `Effect.ignore` expresses ignored failure more directly than `Effect.catch` returning `Effect.void`. effect(catchToIgnore)

3010                   Effect.catch(() => Effect.void),
                       ~~~~~~~~~~~~

src/orchestration-v2/Adapters/CodexAdapterV2.ts:7177:26 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

7177                   return yield* Effect.fail(failedTermination.error);
                              ~~~~~

src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts:33:38 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeSync` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownSync`. effect(preferTypedSchemaDecoder)

33 const DEFAULT_GROK_SETTINGS = Schema.decodeUnknownSync(GrokSettings)({});
                                        ~~~~~~~~~~~~~~~~~

src/orchestration-v2/Adapters/MuseAdapterV2.testkit.ts:409:38 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeSync` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownSync`. effect(preferTypedSchemaDecoder)

409 const DEFAULT_MUSE_SETTINGS = Schema.decodeUnknownSync(MuseSettings)({ enabled: true });
                                         ~~~~~~~~~~~~~~~~~

src/orchestration-v2/CheckpointCaptureService.ts:235:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("CheckpointCaptureServiceV2.execute")((input) => { ... })`. effect(effectFnOpportunity)

235       execute: (input) =>
          ~~~~~~~

src/orchestration-v2/CheckpointRestoreSafety.test.ts:104:24 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

104             get: () => Effect.succeed(Option.some({ workspaceRoot: parent } as never)),
                           ~~~~~~~~~~~~~~

src/orchestration-v2/CheckpointRestoreSafety.ts:40:13 - suggestion TS377116: `Effect.catchIf` expresses selective recovery more directly than `Effect.catch` with a conditional `Effect.fail` passthrough. effect(catchConditionalRefailToCatchIf)

40             Effect.catch((error) =>
               ~~~~~~~~~~~~

src/orchestration-v2/CheckpointRestoreSafety.ts:80:17 - suggestion TS377116: `Effect.catchIf` expresses selective recovery more directly than `Effect.catch` with a conditional `Effect.fail` passthrough. effect(catchConditionalRefailToCatchIf)

80                 Effect.catch((error) =>
                   ~~~~~~~~~~~~

src/orchestration-v2/CheckpointRollbackService.test.ts:232:22 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

232               return Effect.succeed(Option.some({ workspaceRoot } as never));
                         ~~~~~~~~~~~~~~

src/orchestration-v2/ClaudeAutomaticDelivery.integration.test.ts:142:28 - suggestion TS377111: `AbortController` is manually constructed inside Effect code. Use `Effect.abortSignal` for Effect-managed cancellation. effect(abortControllerInEffect)

142         const batchAbort = new AbortController();
                               ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/CommandOutputHub.test.ts:166:5 - suggestion TS377120: `Effect.filterOrElse` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

166     Effect.flatMap((frame) =>
        ~~~~~~~~~~~~~~

src/orchestration-v2/CommandReceiptStore.ts:164:29 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

164               onNone: () => Effect.succeed(Option.none()),
                                ~~~~~~~~~~~~~~

src/orchestration-v2/CommandReceiptStore.ts:167:21 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

167                   ? Effect.succeed(Option.none())
                        ~~~~~~~~~~~~~~

src/orchestration-v2/CommandReceiptStore.ts:168:58 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

168                   : fromApplicationReceipt(receipt).pipe(Effect.map(Option.some)),
                                                             ~~~~~~~~~~

src/orchestration-v2/CommandReceiptStore.ts:183:17 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

183               ? Effect.succeed(Option.none())
                    ~~~~~~~~~~~~~~

src/orchestration-v2/CommandReceiptStore.ts:192:25 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

192                 }).pipe(Effect.map(Option.some)),
                            ~~~~~~~~~~

src/orchestration-v2/EffectOutbox.ts:423:17 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

423               ? Effect.succeed(Option.none())
                    ~~~~~~~~~~~~~~

src/orchestration-v2/EffectOutbox.ts:424:39 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

424               : rowToEffect(row).pipe(Effect.map(Option.some));
                                          ~~~~~~~~~~

src/orchestration-v2/EffectWorker.test.ts:109:20 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

109         get: () => Effect.succeed(Option.none()),
                       ~~~~~~~~~~~~~~

src/orchestration-v2/EffectWorker.test.ts:342:24 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

342       claimNext: () => Effect.succeed(Option.some(claimedEffect)),
                           ~~~~~~~~~~~~~~

src/orchestration-v2/EffectWorker.test.ts:409:24 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

409       claimNext: () => Effect.succeed(Option.some(claimedEffect)),
                           ~~~~~~~~~~~~~~

src/orchestration-v2/EffectWorker.test.ts:476:24 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

476       claimNext: () => Effect.succeed(Option.some(claimedEffect)),
                           ~~~~~~~~~~~~~~

src/orchestration-v2/EffectWorker.test.ts:477:18 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

477       get: () => Effect.succeed(Option.some(claimedEffect)),
                     ~~~~~~~~~~~~~~

src/orchestration-v2/EffectWorker.ts:98:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestrationEffectExecutorV2.execute")((effect, options) => { ... })`. effect(effectFnOpportunity)

98       execute: (effect, options) => {
         ~~~~~~~

src/orchestration-v2/EffectWorker.ts:180:17 - suggestion TS377116: `Effect.catchIf` expresses selective recovery more directly than `Effect.catch` with a conditional `Effect.fail` passthrough. effect(catchConditionalRefailToCatchIf)

180                 Effect.catch((cause) =>
                    ~~~~~~~~~~~~

src/orchestration-v2/EventStore.ts:110:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("EventStoreV2.append")((input) => { ... })`. effect(effectFnOpportunity)

110         append: (input) =>
            ~~~~~~

src/orchestration-v2/EventStore.ts:120:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("EventStoreV2.appendProjectEvent")((event) => { ... })`. effect(effectFnOpportunity)

120         appendProjectEvent: (event) =>
            ~~~~~~~~~~~~~~~~~~

src/orchestration-v2/EventStore.ts:131:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("EventStoreV2.latestSequence")((input) => { ... })`. effect(effectFnOpportunity)

131         latestSequence: (input) =>
            ~~~~~~~~~~~~~~

src/orchestration-v2/FoundationPersistence.test.ts:1963:26 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

1963         claimNext: () => Effect.succeed(Option.some(claimedEffect)),
                              ~~~~~~~~~~~~~~

src/orchestration-v2/FoundationPersistence.test.ts:1965:11 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

1965           Effect.succeed(
               ~~~~~~~~~~~~~~

src/orchestration-v2/FoundationPersistence.test.ts:2835:30 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

2835             nextClaimableAt: Effect.succeed(Option.none()),
                                  ~~~~~~~~~~~~~~

src/orchestration-v2/FoundationPersistence.test.ts:3052:30 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

3052             nextClaimableAt: Effect.succeed(Option.none()),
                                  ~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:11984:7 - suggestion TS377120: `Effect.filterOrFail` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

11984       Effect.flatMap((planned) =>
            ~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12402:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.restartContinuationPending")((run) => { ... })`. effect(effectFnOpportunity)

12402     restartContinuationPending: (run) =>
          ~~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12404:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.awaitRestartContinuation")((run) => { ... })`. effect(effectFnOpportunity)

12404     awaitRestartContinuation: (run) =>
          ~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12407:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.autoArmLimitRecovery")((input) => { ... })`. effect(effectFnOpportunity)

12407     autoArmLimitRecovery: (input) =>
          ~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12435:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.searchThread")((input) => { ... })`. effect(effectFnOpportunity)

12435     searchThread: (input) =>
          ~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12443:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadHistoryPage")((threadId, cursor, throughEntryId, conversationOnly) => { ... })`. effect(effectFnOpportunity)

12443     getThreadHistoryPage: (threadId, cursor, throughEntryId, conversationOnly) =>
          ~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12447:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getTimelinePage")((threadId, options) => { ... })`. effect(effectFnOpportunity)

12447     getTimelinePage: (threadId, options) =>
          ~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12451:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getMessageCount")((threadId) => { ... })`. effect(effectFnOpportunity)

12451     getMessageCount: (threadId) =>
          ~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12455:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getTurnItem")((input) => { ... })`. effect(effectFnOpportunity)

12455     getTurnItem: (input) =>
          ~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12463:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadRecords")((threadId, fields, filter) => { ... })`. effect(effectFnOpportunity)

12463     getThreadRecords: (threadId, fields, filter) =>
          ~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12467:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadProjection")((threadId) => { ... })`. effect(effectFnOpportunity)

12467     getThreadProjection: (threadId) =>
          ~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12471:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getCheckpointContext")((threadId) => { ... })`. effect(effectFnOpportunity)

12471     getCheckpointContext: (threadId) =>
          ~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12475:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadSnapshot")((threadId) => { ... })`. effect(effectFnOpportunity)

12475     getThreadSnapshot: (threadId) =>
          ~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12479:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadSnapshotWindow")((threadId, options) => { ... })`. effect(effectFnOpportunity)

12479     getThreadSnapshotWindow: (threadId, options) =>
          ~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12483:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getShellSnapshot")((options) => { ... })`. effect(effectFnOpportunity)

12483     getShellSnapshot: (options) =>
          ~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12485:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.listActiveSubagentThreadIds")(() => { ... })`. effect(effectFnOpportunity)

12485     listActiveSubagentThreadIds: () =>
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12487:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.listOlderSettledThreads")((query) => { ... })`. effect(effectFnOpportunity)

12487     listOlderSettledThreads: (query) =>
          ~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12489:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.readShellSnapshot")((options) => { ... })`. effect(effectFnOpportunity)

12489     readShellSnapshot: (options) =>
          ~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12496:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadShell")((threadId) => { ... })`. effect(effectFnOpportunity)

12496     getThreadShell: (threadId) =>
          ~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12500:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.findGuestShareThreadId")((shareId) => { ... })`. effect(effectFnOpportunity)

12500     findGuestShareThreadId: (shareId) =>
          ~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/Orchestrator.ts:12502:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("OrchestratorV2.getThreadEventSequence")((threadId) => { ... })`. effect(effectFnOpportunity)

12502     getThreadEventSequence: (threadId) =>
          ~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ProjectSettingsUpgrade.integration.test.ts:160:28 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

160         getInstance: () => Effect.succeed(undefined),
                               ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ProjectStore.ts:269:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectStoreV2.getShell")((projectId) => { ... })`. effect(effectFnOpportunity)

269     getShell: (projectId) => get(projectId).pipe(Effect.map(Option.map(toShell))),
        ~~~~~~~~

src/orchestration-v2/ProjectStore.ts:270:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectStoreV2.listShells")((options) => { ... })`. effect(effectFnOpportunity)

270     listShells: (options) =>
        ~~~~~~~~~~

src/orchestration-v2/ProjectionControlReads.test.ts:279:11 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

279           Effect.succeed(
              ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderAdapterRegistry.ts:78:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapterRegistryV2.get")((instanceId) => { ... })`. effect(effectFnOpportunity)

78       get: (instanceId) =>
         ~~~

src/orchestration-v2/ProviderAdapterRegistry.ts:135:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAdapterRegistryV2.list")(() => { ... })`. effect(effectFnOpportunity)

135       list: () =>
          ~~~~

src/orchestration-v2/ProviderEventIngestor.ts:117:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderTurnAnalytics.record")((properties) => { ... })`. effect(effectFnOpportunity)

117       record: (properties: Readonly<Record<string, unknown>>) =>
          ~~~~~~

src/orchestration-v2/ProviderEventIngestor.ts:833:15 - suggestion TS377120: `Effect.filterOrElse` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

833               Effect.flatMap((storedEvents) =>
                  ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderSessionManager.test.ts:1153:19 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

1153                 : Effect.succeed(Option.some(makeBrowserAccessProject(requestedProjectId))),
                       ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.test.ts:148:13 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

148             Effect.succeed(
                ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.test.ts:701:13 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

701             Effect.succeed(Option.some({ workspaceRoot: "/tmp/native-account-project" } as never)),
                ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.testkit.ts:14:20 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

14     getById: () => Effect.succeed(Option.none()),
                      ~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.ts:204:39 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

204               Effect.catchCause(() => Effect.succeed(undefined)),
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.ts:510:15 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

510               Effect.catchCause((cause) =>
                  ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ProviderTurnStartService.ts:1303:7 - suggestion TS377014: This generator returns an Effect-able value directly, which produces a nested `Effect<Effect<...>>`. If the intended result is the inner Effect value, `return yield*` represents that form. effect(returnEffectInGen)

1303       return runExecution.startRootRun({
           ~~~~~~

src/orchestration-v2/PullRequestWatchReactor.ts:467:53 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

467             ? pullRequests.activity(reference).pipe(Effect.map(Option.some))
                                                        ~~~~~~~~~~

src/orchestration-v2/ResourceCleanupService.ts:49:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ResourceCleanupService.cleanupScheduledTasks")((threadId) => { ... })`. effect(effectFnOpportunity)

49       cleanupScheduledTasks: (threadId: ThreadId) =>
         ~~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ResourceCleanupService.ts:58:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ResourceCleanupService.cleanupTerminals")((threadId) => { ... })`. effect(effectFnOpportunity)

58       cleanupTerminals: (threadId: string) =>
         ~~~~~~~~~~~~~~~~

src/orchestration-v2/ResourceCleanupService.ts:66:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ResourceCleanupService.cleanupPreviews")((threadId) => { ... })`. effect(effectFnOpportunity)

66       cleanupPreviews: (threadId: string) =>
         ~~~~~~~~~~~~~~~

src/orchestration-v2/ResourceCleanupService.ts:74:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ResourceCleanupService.cleanupAttachments")((attachmentIds) => { ... })`. effect(effectFnOpportunity)

74       cleanupAttachments: (attachmentIds: ReadonlyArray<string>) =>
         ~~~~~~~~~~~~~~~~~~

src/orchestration-v2/RunExecutionService.test.ts:1837:16 - suggestion TS377114: `Effect.asSome` expresses wrapping the success value in `Option.some` directly. effect(mapSomeToAsSome)

1837         ).pipe(Effect.map(Option.some)),
                    ~~~~~~~~~~

src/orchestration-v2/RunExecutionService.ts:926:15 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

926               Effect.catchCause((cause) =>
                  ~~~~~~~~~~~~~~~~~

src/orchestration-v2/RuntimePolicy.test.ts:90:9 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

90         Effect.succeed(
           ~~~~~~~~~~~~~~

src/orchestration-v2/RuntimePolicy.ts:54:3 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("RuntimePolicyV2.resolve")((input) => { ... })`. effect(effectFnOpportunity)

54   resolve: (input) =>
     ~~~~~~~

src/orchestration-v2/RuntimeRequestService.test.ts:29:7 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

29       Effect.succeed(
         ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLaunchService.test.ts:189:33 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

189       getByWorkspaceRoot: () => Effect.succeed(Option.some(project)),
                                    ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLaunchService.test.ts:220:32 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

220         folderForThread: () => Effect.succeed(Option.none()),
                                   ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:91:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.archive")((input) => { ... })`. effect(effectFnOpportunity)

91     archive: (input) =>
       ~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:97:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.unarchive")((input) => { ... })`. effect(effectFnOpportunity)

97     unarchive: (input) =>
       ~~~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:103:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.delete")((input) => { ... })`. effect(effectFnOpportunity)

103     delete: (input) =>
        ~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:109:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.updateMetadata")((input) => { ... })`. effect(effectFnOpportunity)

109     updateMetadata: (input) =>
        ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:118:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.setRuntimeMode")((input) => { ... })`. effect(effectFnOpportunity)

118     setRuntimeMode: (input) =>
        ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:125:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.setInteractionMode")((input) => { ... })`. effect(effectFnOpportunity)

125     setInteractionMode: (input) =>
        ~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadLifecycleService.ts:132:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadLifecycleService.setModelSelection")((input) => { ... })`. effect(effectFnOpportunity)

132     setModelSelection: (input) =>
        ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:710:7 - suggestion TS377120: `Effect.filterOrFail` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

710       Effect.flatMap((projection) =>
          ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:727:5 - suggestion TS377015: This expression contains chained `pipe` calls that can be simplified to a single `pipe` call. effect(unnecessaryPipeChain)

727     ensureProjectionTranscript(input.threadId)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
728       .pipe(Effect.andThen(orchestrator.getThreadRecords(input.threadId, fields, filter)))
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
747         ),
    ~~~~~~~~~~
748       );
    ~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:738:9 - suggestion TS377120: `Effect.filterOrFail` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

738         Effect.flatMap((projection) =>
            ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1199:43 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

1199     if (failures[0] !== undefined) return yield* Effect.fail(failures[0]);
                                               ~~~~~

src/orchestration-v2/ThreadManagementService.ts:1210:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.searchThread")((input) => { ... })`. effect(effectFnOpportunity)

1210     searchThread: (input) =>
         ~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1215:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.getThreadHistoryPage")((threadId, cursor, throughEntryId, conversationOnly) => { ... })`. effect(effectFnOpportunity)

1215     getThreadHistoryPage: (threadId, cursor, throughEntryId, conversationOnly) =>
         ~~~~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1221:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.getTimelinePage")((threadId, options) => { ... })`. effect(effectFnOpportunity)

1221     getTimelinePage: (threadId, options) =>
         ~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1225:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.getMessageCount")((threadId) => { ... })`. effect(effectFnOpportunity)

1225     getMessageCount: (threadId) =>
         ~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1229:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.getTurnItem")((input) => { ... })`. effect(effectFnOpportunity)

1229     getTurnItem: (input) =>
         ~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1234:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadManagementService.getThreadRecords")((threadId, fields, filter) => { ... })`. effect(effectFnOpportunity)

1234     getThreadRecords: (threadId, fields, filter) =>
         ~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadManagementService.ts:1276:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("LegacyV1ThreadImporter.LegacyV1ThreadImporter.ensureTranscript")(() => { ... })`. effect(effectFnOpportunity)

1276     ensureTranscript: () => Effect.succeed({ importedThreadCount: 0, importedMessageCount: 0 }),
         ~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadPullRequestService.test.ts:118:29 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

118             getShell: () => Effect.succeed(Option.some(project)),
                                ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadPullRequestService.test.ts:237:31 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

237               getShell: () => Effect.succeed(Option.some(project)),
                                  ~~~~~~~~~~~~~~

src/orchestration-v2/ThreadPullRequestService.ts:322:17 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

322                 Effect.catchCause((cause) =>
                    ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadSettlementService.ts:353:11 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

353           Effect.catchCause((cause) =>
              ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadSettlementService.ts:510:11 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

510           Effect.catchCause((cause) =>
              ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadSettlementService.ts:528:7 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

528       Effect.catchCause((cause) =>
          ~~~~~~~~~~~~~~~~~

src/orchestration-v2/ThreadSettlementService.ts:593:9 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

593         Effect.catchCause((cause) =>
            ~~~~~~~~~~~~~~~~~

src/orchestration-v2/TurnItemPositionStore.ts:106:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TurnItemPositionStoreV2.normalize")((item, runOrdinal) => { ... })`. effect(effectFnOpportunity)

106       normalize: (item, runOrdinal) =>
          ~~~~~~~~~

src/orchestration-v2/http.test.ts:54:23 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeSync` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownSync`. effect(preferTypedSchemaDecoder)

54 const thread = Schema.decodeUnknownSync(OrchestrationV2AppThread)({
                         ~~~~~~~~~~~~~~~~~

src/orchestration-v2/http.ts:248:11 - suggestion TS377012: This Effect generator contains `try/catch`; in this context, error handling is expressed with Effect APIs such as Effect.try, Effect.tryPromise, Effect.catch, Effect.catchTag). effect(tryCatchInEffectGen)

248           try {
              ~~~~~
249             decodeThreadHistoryCursor(args.query.cursor);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
253             return yield* failEnvironmentInternal("orchestration_thread_history_failed", cause);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
254           }
    ~~~~~~~~~~~

src/orchestration-v2/runtimeLayer.test.ts:120:18 - suggestion TS377117: `Effect.succeedNone` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

120   getById: () => Effect.succeed(Option.none()),
                     ~~~~~~~~~~~~~~

src/orchestration-v2/runtimeLayer.test.ts:997:11 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

997           Effect.succeed(
              ~~~~~~~~~~~~~~

src/orchestration-v2/testkit/CommandOutputRecorder.ts:37:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("CommandOutputHub.CommandOutputHub.append")((input) => { ... })`. effect(effectFnOpportunity)

37         append: (input) =>
           ~~~~~~

src/orchestration-v2/testkit/OrchestratorScenario.ts:282:13 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("awaitDispatch")(function*(key) { ... })`. effect(effectFnOpportunity)

282       const awaitDispatch = (key: string) =>
                ~~~~~~~~~~~~~

src/orchestration-v2/testkit/ProviderReplayHarness.ts:445:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ThreadTitleRegenerationService.ThreadTitleRegenerationService.execute")(() => { ... })`. effect(effectFnOpportunity)

445       execute: () => Effect.void,
          ~~~~~~~

src/persistence/PullRequestFilesViewed.ts:87:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("PullRequestFilesViewedRepository.list")((input) => { ... })`. effect(effectFnOpportunity)

87     list: (input) =>
       ~~~~

src/persistence/PullRequestFilesViewed.ts:97:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("PullRequestFilesViewedRepository.set")((input) => { ... })`. effect(effectFnOpportunity)

97     set: (input) =>
       ~~~

src/persistence/PullRequestReviewGuides.ts:54:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("PullRequestReviewGuideRepository.get")((key) => { ... })`. effect(effectFnOpportunity)

54     get: (key) =>
       ~~~

src/persistence/PullRequestReviewGuides.ts:64:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("PullRequestReviewGuideRepository.put")((key, guide) => { ... })`. effect(effectFnOpportunity)

64     put: (key, guide) =>
       ~~~

src/persistence/initializeV2Database.ts:45:9 - suggestion TS377116: `Effect.catchIf` expresses selective recovery more directly than `Effect.catch` with a conditional `Effect.fail` passthrough. effect(catchConditionalRefailToCatchIf)

45         Effect.catch((error) =>
           ~~~~~~~~~~~~

src/preview/DesktopBrowserChannel.ts:67:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.awaitAttached")(() => { ... })`. effect(effectFnOpportunity)

67       awaitAttached: () => Effect.succeed(false),
         ~~~~~~~~~~~~~

src/preview/DesktopBrowserChannel.ts:70:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.isAttached")(() => { ... })`. effect(effectFnOpportunity)

70       isAttached: () => Effect.succeed(false),
         ~~~~~~~~~~

src/preview/DesktopBrowserChannel.ts:71:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.endpoint")(() => { ... })`. effect(effectFnOpportunity)

71       endpoint: () => Effect.die("No desktop app is attached to this server."),
         ~~~~~~~~

src/preview/DesktopBrowserChannel.ts:72:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.pointer")(() => { ... })`. effect(effectFnOpportunity)

72       pointer: () => Effect.void,
         ~~~~~~~

src/preview/DesktopBrowserChannel.ts:185:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.awaitAttached")((key, timeout) => { ... })`. effect(effectFnOpportunity)

185     awaitAttached: (key, timeout) =>
        ~~~~~~~~~~~~~

src/preview/DesktopBrowserChannel.ts:207:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.isAttached")((key) => { ... })`. effect(effectFnOpportunity)

207     isAttached: (key) => Effect.sync(() => attachedTabs.has(keyOf(key))),
        ~~~~~~~~~~

src/preview/DesktopBrowserChannel.ts:209:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopBrowserChannel.pointer")((key, pointer) => { ... })`. effect(effectFnOpportunity)

209     pointer: (key, pointer) => command({ type: "pointer", ...key, ...pointer }),
        ~~~~~~~

src/preview/ServerBrowser.ts:472:23 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

472     executable: () => Effect.runPromise(previewBrowser.executable),
                          ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:678:9 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

678       ? Effect.runPromise(
            ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:687:25 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

687     const scope = await Effect.runPromise(Scope.make());
                            ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:689:30 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

689       const endpoint = await Effect.runPromise(
                                 ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:699:17 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

699           await Effect.runPromise(Scope.close(scope, Exit.void));
                    ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:703:13 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

703       await Effect.runPromise(Scope.close(scope, Exit.void));
                ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1185:11 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1185     await Effect.runPromise(
               ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1678:17 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1678         : await Effect.runPromise(
                     ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1742:21 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1742             ? await Effect.runPromise(
                         ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1745:58 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

1745                     ServerBrowserTabNotFoundError: () => Effect.succeed(undefined),
                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1751:38 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1751           const { sessions } = await Effect.runPromise(
                                          ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1778:19 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1778             await Effect.runPromise(
                       ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1809:21 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1809               await Effect.runPromise(
                         ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1873:13 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1873       await Effect.runPromise(manager.close({ threadId: tab.threadId, tabId: tab.tabId }));
                 ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1940:15 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1940         await Effect.runPromise(
                   ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:1952:32 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

1952         const snapshot = await Effect.runPromise(
                                    ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowser.ts:2198:15 - suggestion TS377074: `Effect.runPromise` is called inside an Effect with a separate services invocation. In this context, child Effects run with the surrounding services, which can be accessed through `Effect.context` and `Effect.runPromiseWith`. effect(runEffectInsideEffect)

2198         await Effect.runPromise(
                   ~~~~~~~~~~~~~~~~~

src/preview/ServerBrowserStream.ts:179:13 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("receive")((chunk) => { ... })`. effect(effectFnOpportunity)

179       const receive = (chunk: Uint8Array | string) => {
                ~~~~~~~

src/preview/ServerBrowserStream.ts:209:5 - suggestion TS377095: `Effect.orElseSucceed` expresses the same recovery more directly than `Effect.catch` followed by `Effect.succeed`. effect(catchToOrElseSucceed)

209     Effect.catch(() => Effect.succeed(HttpServerResponse.empty())),
        ~~~~~~~~~~~~

src/process/externalLauncher.ts:822:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ExternalLauncher.resolveAvailableEditors")(() => { ... })`. effect(effectFnOpportunity)

822     resolveAvailableEditors: () => cachedAvailableEditors,
        ~~~~~~~~~~~~~~~~~~~~~~~

src/process/externalLauncher.ts:823:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ExternalLauncher.resolveFileManagerRevealKind")(() => { ... })`. effect(effectFnOpportunity)

823     resolveFileManagerRevealKind: () =>
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/process/externalLauncher.ts:827:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ExternalLauncher.launchBrowser")((target) => { ... })`. effect(effectFnOpportunity)

827     launchBrowser: (target) =>
        ~~~~~~~~~~~~~

src/process/externalLauncher.ts:831:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ExternalLauncher.launchEditor")((input) => { ... })`. effect(effectFnOpportunity)

831     launchEditor: (input) =>
        ~~~~~~~~~~~~

src/project/AgentSessionImporter.test.ts:212:15 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

212               Effect.succeed(
                  ~~~~~~~~~~~~~~

src/project/ManagedProjectFolders.ts:333:13 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

333           ? Effect.succeed(Option.some(folderFor(id.slice(-8))))
                ~~~~~~~~~~~~~~

src/project/ManagedProjectFolders.ts:335:15 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

335             ? Effect.succeed(Option.some(fullFolder))
                  ~~~~~~~~~~~~~~

src/project/ProjectCloneTracker.ts:421:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectCloneTracker.start")((input, hooks) => { ... })`. effect(effectFnOpportunity)

421     start: (input, hooks) => locked(start(input, hooks)),
        ~~~~~

src/project/ProjectCloneTracker.ts:422:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectCloneTracker.cancel")((projectId) => { ... })`. effect(effectFnOpportunity)

422     cancel: (projectId) => locked(cancel(projectId)),
        ~~~~~~

src/project/ProjectCloneTracker.ts:423:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectCloneTracker.retry")((projectId) => { ... })`. effect(effectFnOpportunity)

423     retry: (projectId) => locked(retry(projectId)),
        ~~~~~

src/project/ProjectCloneTracker.ts:424:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProjectCloneTracker.discard")((projectId) => { ... })`. effect(effectFnOpportunity)

424     discard: (projectId) => locked(discard(projectId)),
        ~~~~~~~

src/provider/CodexChatGptHandoff.ts:21:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSecretStore.ServerSecretStore.get")((key) => { ... })`. effect(effectFnOpportunity)

21         get: (key) => Effect.sync(() => Option.fromUndefinedOr(bytes.get(key))),
           ~~~

src/provider/CodexChatGptHandoff.ts:22:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSecretStore.ServerSecretStore.set")((key, value) => { ... })`. effect(effectFnOpportunity)

22         set: (key, value) =>
           ~~~

src/provider/CodexChatGptHandoff.ts:26:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSecretStore.ServerSecretStore.remove")((key) => { ... })`. effect(effectFnOpportunity)

26         remove: (key) =>
           ~~~~~~

src/provider/CodexChatGptHandoff.ts:30:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSecretStore.ServerSecretStore.create")(() => { ... })`. effect(effectFnOpportunity)

30         create: () => Effect.die("Handoff does not create persistent secrets."),
           ~~~~~~

src/provider/CodexChatGptHandoff.ts:31:9 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ServerSecretStore.ServerSecretStore.getOrCreateRandom")(() => { ... })`. effect(effectFnOpportunity)

31         getOrCreateRandom: () => Effect.die("Handoff uses the destination environment identity."),
           ~~~~~~~~~~~~~~~~~

src/provider/CodexInstallation.ts:205:26 - suggestion TS377112: This input is already assignable to the schema's Encoded type. Use `decodeEffect` to preserve compile-time type checking instead of discarding the input type through `decodeUnknownEffect`. effect(preferTypedSchemaDecoder)

205     return yield* Schema.decodeUnknownEffect(Schema.fromJsonString(schema))(
                             ~~~~~~~~~~~~~~~~~~~

src/provider/CodexProvider.ts:559:11 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

559         ? Effect.succeed(undefined)
              ~~~~~~~~~~~~~~~~~~~~~~~~~

src/provider/ModelManifest.ts:270:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ModelCatalog.ModelCatalog.current")((driverKind) => { ... })`. effect(effectFnOpportunity)

270       current: (driverKind) =>
          ~~~~~~~

src/provider/ProviderAuthService.test.ts:284:24 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

284                 return yield* Effect.fail(
                           ~~~~~

src/provider/ProviderAuthService.ts:209:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderAuthService.importProfile")((input) => { ... })`. effect(effectFnOpportunity)

209     importProfile: (input) =>
        ~~~~~~~~~~~~~

src/provider/ProviderHostLive.ts:39:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("ProviderHost.ProviderHost.credentials")((namespace, bindingId) => { ... })`. effect(effectFnOpportunity)

39       credentials: (namespace, bindingId) =>
         ~~~~~~~~~~~

src/pullRequest/PullRequestService.ts:2957:7 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

2957       Effect.catchCause((cause) =>
           ~~~~~~~~~~~~~~~~~

src/pullRequest/PullRequestService.ts:3388:7 - suggestion TS377116: `Effect.catchCauseIf` expresses selective recovery more directly than `Effect.catchCause` with a conditional `Effect.failCause` passthrough. effect(catchConditionalRefailToCatchIf)

3388       Effect.catchCause((cause) =>
           ~~~~~~~~~~~~~~~~~

src/pullRequest/PullRequestService.ts:3624:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("PullRequestService.listStats")((input) => { ... })`. effect(effectFnOpportunity)

3624     listStats: (input) =>
         ~~~~~~~~~

src/relay/AgentAwarenessRelay.test.ts:273:9 - suggestion TS377117: `Effect.succeedSome` expresses this Option success value directly. effect(preferSucceedSomeOrNone)

273         Effect.succeed(
            ~~~~~~~~~~~~~~

src/relay/AgentAwarenessRelay.ts:846:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("AgentAwarenessRelay.requestCatchUp")(() => { ... })`. effect(effectFnOpportunity)

846     requestCatchUp: () => Queue.offer(catchUpRequests, undefined).pipe(Effect.asVoid),
        ~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:640:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.requestDesktopUpdate")((requestId) => { ... })`. effect(effectFnOpportunity)

640     requestDesktopUpdate: (requestId) =>
        ~~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:646:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.commitDesktopUpdate")((requestId) => { ... })`. effect(effectFnOpportunity)

646     commitDesktopUpdate: (requestId) =>
        ~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:648:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.cancelDesktopUpdate")((requestId) => { ... })`. effect(effectFnOpportunity)

648     cancelDesktopUpdate: (requestId) =>
        ~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:697:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.setDiagnosticsDemand")(() => { ... })`. effect(effectFnOpportunity)

697       setDiagnosticsDemand: () => Effect.void,
          ~~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:698:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.requestDesktopUpdate")(() => { ... })`. effect(effectFnOpportunity)

698       requestDesktopUpdate: () => Effect.void,
          ~~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:699:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.commitDesktopUpdate")(() => { ... })`. effect(effectFnOpportunity)

699       commitDesktopUpdate: () => Effect.void,
          ~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/DesktopTelemetryReceiver.ts:700:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("DesktopTelemetryReceiver.cancelDesktopUpdate")(() => { ... })`. effect(effectFnOpportunity)

700       cancelDesktopUpdate: () => Effect.void,
          ~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/NativeTelemetryClient.ts:1091:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("NativeTelemetryClient.readHistory")(() => { ... })`. effect(effectFnOpportunity)

1091       readHistory: () =>
           ~~~~~~~~~~~

src/resourceTelemetry/NativeTelemetryClient.ts:1097:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("NativeTelemetryClient.setExternalProcesses")(() => { ... })`. effect(effectFnOpportunity)

1097       setExternalProcesses: () => Effect.void,
           ~~~~~~~~~~~~~~~~~~~~

src/resourceTelemetry/NativeTelemetryClient.ts:1098:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("NativeTelemetryClient.setHostPowerState")(() => { ... })`. effect(effectFnOpportunity)

1098       setHostPowerState: () => Effect.void,
           ~~~~~~~~~~~~~~~~~

src/scheduledTasks/ScheduledTaskService.ts:1112:31 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

1112                             ? Effect.succeed(undefined)
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~

src/secrets/SecretRequests.test.ts:175:30 - suggestion TS377113: `Effect.forEach` expresses this effectful array mapping more directly than `Effect.all` over `Array#map`. effect(allOfMapToForEach)

175       const results = yield* Effect.all(
                                 ~~~~~~~~~~

src/server.ts:489:5 - suggestion TS377014: This generator returns an Effect-able value directly, which produces a nested `Effect<Effect<...>>`. If the intended result is the inner Effect value, `return yield*` represents that form. effect(returnEffectInGen)

489     return Effect.gen(function* () {
        ~~~~~~

src/serverRuntimeStartup.test.ts:209:25 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

209           prepareTrial: Effect.succeed(undefined),
                            ~~~~~~~~~~~~~~~~~~~~~~~~~

src/serverSettings.test.ts:413:30 - suggestion TS377113: `Effect.forEach` expresses this effectful array mapping more directly than `Effect.all` over `Array#map`. effect(allOfMapToForEach)

413       const results = yield* Effect.all(
                                 ~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:199:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.listChangeRequests")((input) => { ... })`. effect(effectFnOpportunity)

199     listChangeRequests: (input) =>
        ~~~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:204:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.getChangeRequest")((input) => { ... })`. effect(effectFnOpportunity)

204     getChangeRequest: (input) =>
        ~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:209:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.createChangeRequest")((input) => { ... })`. effect(effectFnOpportunity)

209     createChangeRequest: (input) =>
        ~~~~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:214:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.getRepositoryCloneUrls")((input) => { ... })`. effect(effectFnOpportunity)

214     getRepositoryCloneUrls: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:219:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.createRepository")((input) => { ... })`. effect(effectFnOpportunity)

219     createRepository: (input) => provider.createRepository(input),
        ~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:220:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.getDefaultBranch")((input) => { ... })`. effect(effectFnOpportunity)

220     getDefaultBranch: (input) =>
        ~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:225:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProvider.SourceControlProvider.checkoutChangeRequest")((input) => { ... })`. effect(effectFnOpportunity)

225     checkoutChangeRequest: (input) =>
        ~~~~~~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlProviderRegistry.ts:340:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlProviderRegistry.resolve")((input) => { ... })`. effect(effectFnOpportunity)

340       resolve: (input) => resolveHandle(input).pipe(Effect.map((handle) => handle.provider)),
          ~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:385:7 - suggestion TS377116: `Effect.catchIf` expresses selective recovery more directly than `Effect.catch` with a conditional `Effect.fail` passthrough. effect(catchConditionalRefailToCatchIf)

385       Effect.catch((sshError) =>
          ~~~~~~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:524:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlRepositoryService.lookupRepository")((input) => { ... })`. effect(effectFnOpportunity)

524     lookupRepository: (input) =>
        ~~~~~~~~~~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:526:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlRepositoryService.prepareClone")((input) => { ... })`. effect(effectFnOpportunity)

526     prepareClone: (input) =>
        ~~~~~~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:533:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlRepositoryService.cloneRepository")((input, options) => { ... })`. effect(effectFnOpportunity)

533     cloneRepository: (input, options) =>
        ~~~~~~~~~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:540:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlRepositoryService.discardClone")((destinationPath) => { ... })`. effect(effectFnOpportunity)

540     discardClone: (destinationPath) =>
        ~~~~~~~~~~~~

src/sourceControl/SourceControlRepositoryService.ts:544:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("SourceControlRepositoryService.publishRepository")((input) => { ... })`. effect(effectFnOpportunity)

544     publishRepository: (input) =>
        ~~~~~~~~~~~~~~~~~

src/storageCleanup.ts:695:14 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

695       return yield* Effect.fail(
                 ~~~~~

src/telemetry/AnalyticsService.ts:98:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("AnalyticsService.record")(() => { ... })`. effect(effectFnOpportunity)

98       record: () => Effect.void,
         ~~~~~~

src/telemetry/AnalyticsService.ts:100:7 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("AnalyticsService.recordOwners")(() => { ... })`. effect(effectFnOpportunity)

100       recordOwners: () => Effect.void,
          ~~~~~~~~~~~~

src/telemetry/AnalyticsService.ts:310:62 - suggestion TS377132: `Effect.andThen` expresses this sequencing more directly than `Effect.flatMap` with a zero-parameter callback. effect(flatMapIgnoredParamToAndThen)

310   yield* Effect.forever(Effect.sleep(FLUSH_INTERVAL_MS).pipe(Effect.flatMap(() => flushWhenDue)), {
                                                                 ~~~~~~~~~~~~~~

src/textGeneration/CodexTextGeneration.ts:85:13 - suggestion TS377099: `Effect.ignore` expresses ignored failure more directly than `Effect.catch` returning `Effect.void`. effect(catchToIgnore)

85       .pipe(Effect.catch(() => Effect.void));
               ~~~~~~~~~~~~

src/textGeneration/TextGeneration.ts:60:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TextGeneration.generateCommitMessage")((input) => { ... })`. effect(effectFnOpportunity)

60     generateCommitMessage: (input) =>
       ~~~~~~~~~~~~~~~~~~~~~

src/textGeneration/TextGeneration.ts:64:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TextGeneration.generatePrContent")((input) => { ... })`. effect(effectFnOpportunity)

64     generatePrContent: (input) =>
       ~~~~~~~~~~~~~~~~~

src/textGeneration/TextGeneration.ts:68:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TextGeneration.generateBranchName")((input) => { ... })`. effect(effectFnOpportunity)

68     generateBranchName: (input) =>
       ~~~~~~~~~~~~~~~~~~

src/textGeneration/TextGeneration.ts:72:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TextGeneration.generateReviewGuide")((input) => { ... })`. effect(effectFnOpportunity)

72     generateReviewGuide: (input) =>
       ~~~~~~~~~~~~~~~~~~~

src/textGeneration/TextGeneration.ts:76:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("TextGeneration.generateThreadTitle")((input) => { ... })`. effect(effectFnOpportunity)

76     generateThreadTitle: (input) =>
       ~~~~~~~~~~~~~~~~~~~

src/usage/UsageService.ts:165:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("UsageService.readSummary")((input) => { ... })`. effect(effectFnOpportunity)

165     readSummary: (input) =>
        ~~~~~~~~~~~

src/usage/UsageService.ts:626:9 - suggestion TS377015: This expression contains chained `pipe` calls that can be simplified to a single `pipe` call. effect(unnecessaryPipeChain)

626         usageInstances(driver, settings)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
627           .pipe(
    ~~~~~~~~~~~~~~~~
... 
648             Effect.provideContext(readerContext),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
649           ),
    ~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:3964:9 - suggestion TS377120: `Effect.filterOrElse` expresses this conditional validation more directly than `Effect.flatMap` with an identity `Effect.succeed` branch. effect(flatMapConditionalToFilterOrFail)

3964         Effect.flatMap((result) =>
             ~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4448:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.commit")((cwd, subject, body, options) => { ... })`. effect(effectFnOpportunity)

4448     commit: (cwd, subject, body, options) =>
         ~~~~~~

src/vcs/GitVcsDriverCore.ts:4450:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.pushCurrentBranch")((cwd, fallbackBranch, options) => { ... })`. effect(effectFnOpportunity)

4450     pushCurrentBranch: (cwd, fallbackBranch, options) =>
         ~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4452:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.pullCurrentBranch")((cwd) => { ... })`. effect(effectFnOpportunity)

4452     pullCurrentBranch: (cwd) => withListRefsInvalidation(cwd, pullCurrentBranch(cwd)),
         ~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4460:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.createWorktree")((input, options) => { ... })`. effect(effectFnOpportunity)

4460     createWorktree: (input, options) =>
         ~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4462:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.fetchRefIntoBranch")((input) => { ... })`. effect(effectFnOpportunity)

4462     fetchRefIntoBranch: (input) => withListRefsInvalidation(input.cwd, fetchRefIntoBranch(input)),
         ~~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4465:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.refreshCheckedOutBranch")((input) => { ... })`. effect(effectFnOpportunity)

4465     refreshCheckedOutBranch: (input) =>
         ~~~~~~~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4467:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.ensureRemote")((input) => { ... })`. effect(effectFnOpportunity)

4467     ensureRemote: (input) => withListRefsInvalidation(input.cwd, ensureRemote(input)),
         ~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4470:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.fetchRemote")((input) => { ... })`. effect(effectFnOpportunity)

4470     fetchRemote: (input) =>
         ~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4485:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.fetchWorktreeBaseCommit")((input) => { ... })`. effect(effectFnOpportunity)

4485     fetchWorktreeBaseCommit: (input) =>
         ~~~~~~~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4487:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.fetchRemoteBranch")((input) => { ... })`. effect(effectFnOpportunity)

4487     fetchRemoteBranch: (input) => withListRefsInvalidation(input.cwd, fetchRemoteBranch(input)),
         ~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4488:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.fetchRemoteTrackingBranch")((input) => { ... })`. effect(effectFnOpportunity)

4488     fetchRemoteTrackingBranch: (input) =>
         ~~~~~~~~~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4490:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.setBranchUpstream")((input) => { ... })`. effect(effectFnOpportunity)

4490     setBranchUpstream: (input) => withListRefsInvalidation(input.cwd, setBranchUpstream(input)),
         ~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4491:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.removeWorktree")((input) => { ... })`. effect(effectFnOpportunity)

4491     removeWorktree: (input) => withListRefsInvalidation(input.cwd, removeWorktree(input)),
         ~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4492:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.pruneWorktrees")((input) => { ... })`. effect(effectFnOpportunity)

4492     pruneWorktrees: (input) => withListRefsInvalidation(input.cwd, pruneWorktrees(input)),
         ~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4493:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.deleteLocalBranch")((input) => { ... })`. effect(effectFnOpportunity)

4493     deleteLocalBranch: (input) => withListRefsInvalidation(input.cwd, deleteLocalBranch(input)),
         ~~~~~~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4494:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.renameBranch")((input) => { ... })`. effect(effectFnOpportunity)

4494     renameBranch: (input) => withListRefsInvalidation(input.cwd, renameBranch(input)),
         ~~~~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4495:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.createRef")((input) => { ... })`. effect(effectFnOpportunity)

4495     createRef: (input) => withListRefsInvalidation(input.cwd, createRef(input)),
         ~~~~~~~~~

src/vcs/GitVcsDriverCore.ts:4496:5 - suggestion TS377047: This expression can be rewritten in the reusable function form `Effect.fn("GitVcsDriver.GitVcsDriver.switchRef")((input) => { ... })`. effect(effectFnOpportunity)

4496     switchRef: (input) => withListRefsInvalidation(input.cwd, switchRef(input)),
         ~~~~~~~~~

src/vcs/VcsStatusBroadcaster.ts:153:5 - suggestion TS377014: This generator returns an Effect-able value directly, which produces a nested `Effect<Effect<...>>`. If the intended result is the inner Effect value, `return yield*` represents that form. effect(returnEffectInGen)

153     return serverSettings.getSettings.pipe(
        ~~~~~~

src/workspace/WorkspaceFileSystem.ts:170:15 - suggestion TS377095: `Effect.orElseSucceed` expresses the same recovery more directly than `Effect.catch` followed by `Effect.succeed`. effect(catchToOrElseSucceed)

170       }).pipe(Effect.catch(() => Effect.succeed(undefined)));
                  ~~~~~~~~~~~~

src/workspace/WorkspaceFileSystem.ts:170:34 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

170       }).pipe(Effect.catch(() => Effect.succeed(undefined)));
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~

src/ws.test.ts:502:47 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

502           resolveFileManagerRevealKind: () => Effect.succeed(undefined),
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~

src/ws.test.ts:673:45 - suggestion TS377016: `Effect.void` represents the same outcome as `Effect.succeed(undefined)` or `Effect.succeed(void 0)`. effect(effectSucceedWithVoid)

673         resolveFileManagerRevealKind: () => Effect.succeed(undefined),
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~

src/ws.ts:1409:23 - suggestion TS377118: `Effect.fromOption` expresses this Option-to-Effect conversion more directly than `Option.match` or an Option tag conditional. effect(optionMatchToFromOption)

1409         return yield* Option.match(project, {
                           ~~~~~~~~~~~~

src/ws.ts:2433:24 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

2433                 return yield* Effect.fail(
                            ~~~~~

src/ws.ts:2442:24 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

2442                 return yield* Effect.fail(
                            ~~~~~

src/ws.ts:2450:24 - suggestion TS377019: This `yield* Effect.fail(...)` passes a yieldable error value. `yield*` represents that value directly without wrapping it in `Effect.fail`. effect(unnecessaryFailYieldableError)

2450                 return yield* Effect.fail(
                            ~~~~~


Waiting for 1 remote cache upload to finish...
---
vp run: 1/2 cache hit (50%), 2/2 successful, 2.38s saved. t3#typecheck not uploaded to the remote cache: HTTP status 502. (Run `vp run --last-details` for full details)

> vp knip 1/2  pass  38.3s

> vp knip 2/2  pass  60.6s

> vp test (1 files)  pass  66.3s

 RUN  v5.0.5 /home/ubuntu/wt/issue-24842


 Test Files  1 passed (1)
      Tests  246 passed (246)
   Start at  23:50:19
   Duration  54.38s (transform 40%, tests 36%, import 13%, setup 11%)


check:changed summary
  pass  format  1.8s
  pass  lint  4.3s
  pass  knip 1/2  38.3s
  pass  knip 2/2  60.6s
  pass  graphql (apps/server)  2.5s
  pass  typecheck (2 packages)  37.8s
  pass  test (1 files)  66.3s
  CI also runs: full test suites, build
  unused patch check skipped: no dependency files changed